shuoyangd

Thanks @mjdenkowski and @fhieber for the initial comments! re: Installation -- Great idea! I'll update the code to reflect that. re: Naming -- Maybe let's do "store"? This establishes some...

Hi All, I have added some unit tests and addressed comments from the previous round. This should be ready for another round of reviews. Both unit tests and style check...

I updated push_pr.yaml following the deepspeed example, together with a few more type annotations to pass mypy tests for python 3.7.

I had the same issue and rolling back to 0.9.0 solved it.

Hi All, All comments from the previous round are addressed and this should be ready for another round of reviews. Thanks, Shuoyang

Hmmm, it seems like faiss only works on macOS with `conda install -c pytorch faiss-cpu` but not with `pip`. The [official document](https://github.com/facebookresearch/faiss/blob/main/INSTALL.md) also recommends installing with `conda` instead of `pip`....

Disabling faiss-related tests on OS X is easier, but after a little digging I also found [this action that should set up miniconda](https://github.com/marketplace/actions/setup-miniconda).

Hi All, I updated the Github workflow and addressed Michael's latest comments in the latest two commits. Looks like workflow checks are all passing now! This is probably a good...

Sorry, thought the 120-line margin is a soft one (quite a few existing lines go beyond that). Just updated again.

Hi @TsukiSama9292 ! Thanks for the great contribution. We have a few requests before we can merge this one but me, @ayushdg and @abhinavg4 will support you along the way....