Results 49 comments of Kit Chan

> I think these lines of code may potentially cause this crash: https://git.ouryahoo.com/mirror-github/SolidWallOfCode--txn_box/blob/0.4.5/plugin/src/ts_util.cc#L1030 https://git.ouryahoo.com/mirror-github/SolidWallOfCode--txn_box/blob/0.4.5/plugin/src/ts_util.cc#L1003 > > The continuation has the only Ptr reference to the mutex. So, when the continuation...

Please add to the existing documentation as well. thanks.

cc @bryancall as discussed, this is the wasm plugin. Please take a look at how the library license is included.

Please note that the contents inside /lib directory are directly coming from the proxy-wasm repo. And I accidentally run clang-format on them so i need to undo that, as well...

Probably we can add au tests later. For now, it is just the initial checkin

Perhaps we should separate this into 2 PRs? one for wamr 1.3.0 another to do skip leading padding for aot?

is there a reason why this cannot be a configuration parameter in records.yaml and has to be a compile time option?