shuchitak

I've tested test modes on my device using the EHCI tool and the tests pass.  @Rocky04, do you have an idea when this would be ready for review? Thanks!

@Rocky04, I tested on an xcore device. The dcd layer for xcore (https://github.com/xmos/fwk_rtos/tree/develop/modules/sw_services/usb/portable) is not part of the tinyusb repo. I added implementation for the new dcd functions (https://github.com/shuchitak/fwk_rtos/commit/08dd360817391498b14ce6469f519b7049d81e2a) and...

> What would be a good way to toggle that feature off? Like a flag to exclude the handling and all the entire code for it in the case the...

Sorry I meant this line, TU_VERIFY(dcd_enter_test_mode && dcd_check_test_mode_support && 0 == tu_u16_low(p_request->wIndex)); If somebody doesn't support this feature, they wouldn't implement these dcd functions and TU_VERIFY would return false. Isn't...

Hmm, I'm not really sure. We could put all the test mode related code in usbd.c in #if TUSB_TEST_MODE_SUPPORT and have the application so something like #define TUSB_TEST_MODE_SUPPORT 1 in...

To have it enabled by default, we could add something like #ifndef TUSB_TEST_MODE_SUPPORT #define TUSB_TEST_MODE_SUPPORT 1 #endif in tusb_options.h. So in tusb_config.h, the user would need to explicitly disable it...

Hi @Rocky04, do you have any more thoughts about enabling opt-out for this feature through a #ifdef? Are you planning to add this to usbd.c? Some of the tests are...

@Rocky04, I agree, a simple opt out based on a define sounds good. Something like this? diff --git a/src/device/usbd.c b/src/device/usbd.c index 83217a869..4b30a7447 100644 --- a/src/device/usbd.c +++ b/src/device/usbd.c @@ -731,6 +731,7...