Barney Hanlon comments

Results 6 comments of


                                            Barney Hanlon

Visually indicate when a swap has been performed

You could have the icon change colour. Perhaps instead of a brown turd, it can be white like evil-smelling dogshit?

Visually indicate when a swap has been performed

I saw that; I was thinking of making it have three states: turd replacement off, excrement replacement on, and fecal matter replaced.

Visually indicate when a swap has been performed

Perhaps a swarm of flies, then. On Sat, Feb 1, 2014 at 11:55 PM, Brady Wetherington [email protected] wrote: > ## I actually want some kind of textual indicator over the...

Update TimestampBase to allow for DateTimeInterface rather than specific implementation and allow fluent setter for factory usage.

> Widening to `DateTimeInterface` is great, but I'm not sold on making this method fluid, as thats considered a breaking change. @bshaffer I'm surprised it's considered a breaking change, given...

Update TimestampBase to allow for DateTimeInterface rather than specific implementation and allow fluent setter for factory usage.

@bshaffer Having had a look about and discussing with fellow PHP engineers, this feels more like "policy" rather than an actual concern. That makes it no less blocking of course...

Update TimestampBase to allow for DateTimeInterface rather than specific implementation and allow fluent setter for factory usage.

> Adding a return value doesn't seem like a breaking change unless it would break existing code somehow. > > However I have a different concern about making it fluent:...