Shridhar Shatrughan

Results 8 comments of Shridhar Shatrughan

I've been working on an implementation for the bug. The idea is to add React refs for the first and last list items in the `items` prop (will be used...

I do realize that the third party component RCTooltip makes it not so easy to close the menu. Welcome any suggestions here. I don't see suggestions regarding this in parallel...

> There's a UX mockup in the issue - [#5858 (comment)](https://github.com/mozilla/addons/issues/2050) - can we have it look like that? Sure, I will be pushing changes per the UX mockup tomorrow.

Here's the UI after some styling changes, it's now similar to the UX mockup. I've tried to avoid modifying the styling of existing elements (such as the rating and review...

Here's a screenshot of a hard-coded icon to make it simpler to visualize the left-align:

there are some `createInternalReview` calls in [amo/reducers/reviews.js](https://github.com/mozilla/addons-frontend/pull/12426/files#diff-4edafe2eb86f55ac4331e659aebd4a0c306f647c73b4e08ad560de88e03e0b8dR523) that also make the invariant checks in `selectLocalizedContent` fail. What should I do about these? They are invoked via `reviewReducerfunction` in `reducers/test_reviews.js` As...

I assume that some of the existing tests don't have the correct setup. The fix should otherwise be ready to merge. I will move on to other bugs.

@diox I looked at it some time back and couldn't exactly figure out why some existing tests were failing despite the `state.lang` additions. Will look into it again after I'm...