Shravan Narayan
Shravan Narayan
Well its kind of both in a way... This is basically the latter (mutation of wasm tables), but is being used for host calls in the library sandboxing use case....
Sorry, just wrapping some other work. Will update the pr shortly
Made the changes. Hopefully the r15 bit is not too hacky --- i was trying to avoid pulling in new dependencies. Also, restored the stack size in the test. Haven't...
@iximeow looks like the tests pass with the old stack size. I think this is ready for review?
ping :slightly_smiling_face:
Sorry for the delay! Some last minute deadlines on my side. I'll be back to updating this PR and addressing the comments in a day or two
@kripken @sbc100 As you suggested, i think it may be easier to upstream this in batches. So, rather than landing this PR, @talg from our sandboxing team will be submitting...
Reviewing! Although its getting a bit late in my local timezone (I am currently traveling), so worst case I'll post an update in the next 12 hours or so
TLDR: we can go ahead and land this instancing support when ready. I'll deal with the incompatibilities they may introduce in our fork @kripken @sbc100 Just wanted to briefly update...
> @shravanrn Thanks, we appreciate this. Of course we'd be grateful for your review. When you do want to upstream the rlbox code, we're happy to help rebase it at...