Shivansh Rai

Results 13 comments of Shivansh Rai

@bradparks I made a few changes to your version to make it a little bit faster. ``` #!/bin/bash set -euo pipefail # Here strings are noted to be faster for...

@mewmew Thanks a lot. I tried a somewhat similar approach earlier, but due to our project structure we encountered an import loop. Although I guess it will be possible to...

@mewmew So I went ahead and following yours and @awalterschulze's instructions refactored the functions for SDT rules into a separate [`ast`](https://github.com/shivansh/gogo/blob/master/src/ast/ast.go) package. Coming to the problem of import cycle, [here](https://github.com/shivansh/gogo/blob/wip/imports/src/ast/ast.go#L173)...

> Am I understanding correctly that this is an attempt to fix #76 Yes. > I wouldn't call this a heuristic, but rather just a possibly better way to do...

@Chyroc Awesome, thanks! Can you also please squash all commits into one, that'd make the git history cleaner.

@awalterschulze oic ; although wouldn't `01` count as a valid whole number representation ?

I guess you were referring to [`FollowingSymbol`](https://github.com/goccmack/gocc/blob/master/internal/parser/lr1/items/item.go#L33) (I wasn't able to find `FollowSymbol`). Although I'm not sure I understand why we'll require this package when dealing with LR(1) items ?

> Maybe it would be cool to use these follow sets for auto completion and to expose an API that allows hints to be given to language users. That would...

> I would want to see how it works, with examples. @awalterschulze Sure. I'll try things first and demonstrate if it works out. > I am a bit worried about...

### Computing follow sets For proceeding with the error recovery, computation of [follow sets](https://sites.tufts.edu/comp181/2013/10/05/first-and-follow-sets/) for all the nonterminals will be required. I don't think this has been implemented in `gocc`...