Shivankar Pilligundla

Results 12 comments of Shivankar Pilligundla

@GouravSardana I would like to work on this as a GSSOC contributor.

@GouravSardana Instead of using xonsh shell. Won't it be a better idea if there is something like a dynamic-cli REPL or shell which gets activated by running some command in...

> Can you come up with a design for this before implementing? I was planning to take input from the input stream/console for commands instead of getting them from command...

![Screenshot from 2022-03-12 23-24-28](https://user-images.githubusercontent.com/60961689/158029206-402a2f5b-c840-436c-bdce-2c6cbe7d13a3.png) ![Screenshot from 2022-03-12 23-24-10](https://user-images.githubusercontent.com/60961689/158029216-d910cb48-4be5-41d9-89a8-e5d8e99422cc.png) Design wise it would look this way. User gets to access this features of dynamic-cli once he enters `dynamic-cli` in command line

> This looks good only. I have 2 concern : > > 1. Do we get the history or the current folder ? Something like that > 2. Can we...

@GouravSardana I made a pull request. Can you review it? I still need to handle some options/commands properly. Commands like -help, -file are not yet handled

> Great work @shivankar-p . Appreciate it, but i have few concerns which will affect us in future: If we do autocomplete with this, problem is this is running a...

Also in chromadb/api/__init__.py ``` @abstractmethod def _add( self, ids: IDs, collection_name: Union[str, Sequence[str]], embedding: Optional[Embeddings], metadata: Optional[Metadatas] = None, documents: Optional[Documents] = None, increment_index: bool = True, ): """Add embeddings...

> Thank you! Can we add tests for get_or_create_collection with embedding functions? Sure. I'll add them

@HammadB I guess the tests are already included for get_or_create_collection with embedding functions. The only change made here was that the abstract class function signature didn't match with the actual...