shishu314

Results 17 comments of shishu314

Seems like all the of tests are skipped: https://github.com/google-gemini/gemini-cli/actions/runs/18042915615 The workflow file is before we added merge_queue_skipper. Our if statements look okay from first glance but suspect that one of...

We have instances where the workflow fails at merge queue skipper and causing the whole e2e to be skipped: https://github.com/google-gemini/gemini-cli/actions/runs/18232148734 Fixing this part doesn't fix all the issues but should...

Update: need approval on the test PR there to test whether or not the updated workflow is working as intended

Standup update: Code changes ready to review, tags WAI, removed all checks on the E2E check job except for when forks have pull_request events

Update: Going to remove the label check and listening to `pull_request_target` event. We actually have a check for approvers permission to run workflow settings set that makes everything obsolete.

Standup update: Cannot test the `pull_request_target` event due to security. Github does not trigger `pull_request_target` events from pull requests from forks. Going to pair with Matt and see if we...

Standup update: Pending review from Matt, code works (I think) but not sure how to test

Same status as yesterday, linking PR: https://github.com/google-gemini/gemini-cli/pull/11028/files Think this works but cannot test

Context: * Currently skipped tests are interpreted as successes (Github built-in) * For forked PRs, everything is skipped because we filter events for only label changes * Once E2E workflow...

E2E changes did not work, specifically because the `pull_request_target` directly bypass protection settings. This is because ``` Workflows triggered by pull_request_target events are run in the context of the base...