Shing Him
Shing Him
done 👍🏼
> However, I don't think the other direction is addressed (malicious sender), and there may be other places where unbounded allocations occur. It seems like a proper audit is in...
The "max expected weight" makes sense for the scripts - these would just apply to the `p2sh` and `p2wsh` constructors, right? > Since we can't predict every use case by...
This may be a stupid question, but from [BIP-77](https://github.com/bitcoin/bips/blob/792e5852506ddc545559894754eec5a05da7a7bb/bip-0077.md#payjoin-uri): > A `req-pj` parameter key, as specified in BIP 21, may be used instead of `pj` to signal that Payjoin is...
> IMO a URI containing both `param` and `req-param` needs to be handled by the `bip21`/`bitcoin_uri` crate as a single `param` parameter. I wouldn't think anyone is using both `param`...
Actually im not sure it actually _can_ be parsed as one param, since it could have different values, but I think sorting out how to handle that should be done...
> or we should make it stricter about duplicates I think i agree with you on this part, especially when there are duplicates of an identical param (like in your...
Good idea, created https://github.com/payjoin/bitcoin_uri/issues/8
Does this mean duplicate the existing rust-payjoin tests that use bitcoind but for BDK, and vice versa for the binding layer tests?
It looks like this lint was added [in 1.78](https://github.com/rust-lang/rust-clippy/blob/master/CHANGELOG.md#rust-178)