rust-payjoin icon indicating copy to clipboard operation
rust-payjoin copied to clipboard

Fix `incompatible_msrv_exceptions` clippy warnings

Open spacebear21 opened this issue 7 months ago • 3 comments

We're ignoring potential MSRV incompatibilities in payjoin-cli with #[allow(clippy::incompatible_msrv_exceptions)]. These should be removed and fixed.

Gotta open an issue to fix these incompatible_msrv exceptions. They're not MSRV compliant!

Originally posted by @DanGould in https://github.com/payjoin/rust-payjoin/pull/750#discussion_r2156194894

spacebear21 avatar Jun 23 '25 20:06 spacebear21

Hey man, would bumping the MSRV to 1.64.0 be an acceptable solution here? i can see it's one of the cleanest solution.

0xZaddyy avatar Jun 25 '25 09:06 0xZaddyy

We must stay on 1.63 to respect the MSRV in the wider rust bitcoin ecosystem (e.g. rust-bitcoin, bdk, rust-lightning).

spacebear21 avatar Jun 25 '25 15:06 spacebear21

It looks like this lint was added in 1.78

shinghim avatar Jul 02 '25 01:07 shinghim