vi

Results 137 comments of vi

A possible future improvement could also be removing `**kwargs` from `Client._get_state`, but that's somewhat out of scope for this PR as it wouldn't affect the public interface at all

> I do like the changes this pr makes, but I am curious about keeping **kwargs and an argument, `allow_extraneous_arguments` which if False, (the default) raises TypeError about unexpected arguments....

Now that extra parameters result in errors, the warning about the `sync_permissions` parameter can be removed, which then also correctly results in an error if provided: https://github.com/DisnakeDev/disnake/blob/4c17fdc45a88dffd215db6b824c8f3e88dfe81b3/disnake/ext/commands/interaction_bot_base.py#L157-L158 I'm pretty sure...

> is this worth putting in a second pr instead of here Would be better in a second PR, but I wouldn't mind if it was added in this one...

> I ran into this problem too. But I tried to create slash command and user command. Creating application commands with the same name but different types was fixed in...

> I don't think we need to deprecate delete_message_days as it is more user friendly than delete_message_seconds. We could potentionally add a timedelta parameter and keep delete_message_days for the time...

> is there an issue on the discord api docs repo concerning this discrepancy? not an issue, but a comment on the relevant PR, https://github.com/discord/discord-api-docs/pull/5219#issuecomment-1192344340 *edit: escalated by devs internally,...

> I don't think we need to deprecate delete_message_days as it is more user friendly than delete_message_seconds. https://github.com/DisnakeDev/disnake/pull/659/commits/78838089800f0457015bccece76a39ad29d6c50f > This should have a documentation note https://github.com/DisnakeDev/disnake/pull/659/commits/f1778175374b04433bf3f6fa5d9b15368d3f89a8 --- Still need to...

api issue seems to be fixed \o/ parameter name still isn't fully decided yet, I've renamed it to `delete_message_duration` for now