vi

Results 137 comments of vi

Thanks for the PR! First off, please try to keep PRs limited to one feature/fix at a time, otherwise it makes maintaining/reviewing much more difficult. Feel free to open as...

The future of this feature seems very uncertain (if not entirely dead): https://github.com/DisnakeDev/disnake/pull/1206#issuecomment-2805367355 https://canary.discord.com/channels/613425648685547541/1130595287078015027/1399911787255562400

> There's a risk to this as `__class__` can be overridden by user code `type(x)` appears to be completely equivalent to `x.__class__` even when overridden by user code: https://github.com/python/cpython/blob/95296a9d40aa2d58502a09e86e2a93c03df23366/Objects/typeobject.c#L5070-L5080 https://github.com/python/cpython/blob/95296a9d40aa2d58502a09e86e2a93c03df23366/Objects/typeobject.c#L7308-L7312...

`ext.commands.ColourConverter` also handles hex colors of various formats, it could probably make use of this new method too.

Are you planning on dropping hoverxref in this or in a separate PR?

Looks good overall! A couple things: - Could we just filter the sphinx 9.0 deprecation warning for the time being, until we replace hoverxref properly? - Low priority, but [this...

A couple more things I noticed: - Sphinx added the classic purple coloring to visited links, the contrast with the documentation's background color is *awful* (contrast ratio of 1.05): I...

(also, for reference: https://github.com/DisnakeDev/disnake/pull/951)

In that case I think `Annotated[int, Range(10, 15)]` might be preferable, but we can definitely bikeshed this a lot. c: More generally, I wouldn't be opposed to supporting `thing: Annotated[str,...

What's the use case here? For copying, `copy.copy/.deepcopy` already works well, I'd say. Additionally, including all fields in the reprs won't work for classes which have a `ConnectionState` reference, which...