Shichu (Stuart) Zhu

Multi-line string literal indentation

2

I'm trying to generate some code using dst package. Part of the code involves multi-line string literal. I'd like to keep the code prettier by propagating the indentation level into...

ygot.TogNMINotifications generated proto message has underlying memory sharing that is not documented

1

https://github.com/openconfig/ygot/blob/6f722a0cce2a47949294afa0c3f23b080d51e501/ygot/render.go#L329 For demo purpose ```Go func demo(root ygot.GoStruct) { ns, _ := ygot.TogNMINotifications(root, 0, ygot.GNMINotificationsConfig{ UsePathElem: true, }) updates := ns[0].GetUpdate() fmt.Println(updates[1].GetPath().GetElem()[0].Name) // prints "interfaces" updates[0].GetPath().GetElem()[0].Name = "somethingElse" fmt.Println(updates[1].GetPath().GetElem()[0].Name) //...

diff.Diff optimization if one input is empty.

1

https://github.com/kylelemons/godebug/blob/e693023230a4a8be4e28c9bd02f467b0534ac08b/diff/diff.go#L37-L40 It seems if one input of Diff is empty, then the algorithm uses O(N^2) space, where N is the size of the other input. The result is I see...