Jason Sherman

[WIP] Rewrite PyROS `UncertaintySet` Docstrings and Improve Validation Robustness

2

## Changes proposed in this PR: - extend valid numeric types to `core.expr.numvalue.native_numeric_types`; add finiteness checks for numeric types (including for array-like entries) - more rigorous validation of structure (shapes...

## Fixes #2441 . ## Summary/Motivation: PyROS currently attempts to access subordinate optimizer solve times through the custom-written routine `pyros.util.get_time_from_solver` invoked on a `SolverResults` object. However, this routine is prone...

Fix PyROS Iteration Logging for Edge Case Involving Discrete Sets

1

## Summary/Motivation: If PyROS is invoked with an instance of `DiscreteScenarioSet` passed through argument `uncertainty_set`, then due to currently implemented algorithmic efficiencies, all separation problems are skipped in the event...

## Summary Consider the following setup: ```python >>> import pyomo.environ as pyo >>> from pyomo.repn.standard_repn import generate_standard_repn >>> m.v = pyo.Var() >>> m.p = pyo.Param(initialize=1, mutable=True) >>> m.con = pyo.Constraint(expr=m.v...

`SolverFactory('gams', **kwds)` ignores keyword arguments

4

## Summary When attempting to construct an instance of an interface to a GAMS solver with optional keyword arguments (such as 'executable' and 'options') passed, the keyword arguments appear to...

## Summary Add `lslack()` and `uslack()` methods for `Var` objects to faciliate quick evaluation of variable lower and upper bound slacks (or violations). ### Rationale Pyomo `Constraint` objects already have...

## Summary/Motivation: Allow PyROS to temporarily adjust the NL writer feasibility tolerance before/after solving subproblems. This change has been instituted to circumvent encounters with `InfeasibleConstraintException` arising from discrepancies between the...

## Summary Move the NL writer presolve tolerance from a module-level constant to a configuration option. ### Rationale #3280 suggested that the hardcoded tolerance `repn.plugins.nl_writer.TOL` of the NL writer presolver...

Overhaul PyROS Preprocessor Subroutine and Subproblem Objects

2

## Fixes #2964. ## Summary/Motivation: Driven by recent algorithmic developments of the PyROS preprocessor, this PR implements sweeping changes to the PyROS preprocessor subroutine and subproblem formulations/object structures. ## Changes...

## Summary As discussed in #2964, the NL writer is expected to raise an `InvalidValueError` upon encountering an invalid constant. However, as of #3353, this may not necessarily happen in...