shekh

LUTPaths: when is it used/useful?

10

There is some weirdness here (hardcoded fully qualified path) https://github.com/gopro/cineform-sdk/blob/1eb2cb7914c38db128b9518ab25dd9f3f24c9890/Codec/lutpath.cpp#L483 and here https://github.com/gopro/cineform-sdk/blob/1eb2cb7914c38db128b9518ab25dd9f3f24c9890/DecoderSDK/SampleMetadata.cpp#L62 Is this actually executed at some point? Also there are registry access, system variable access etc. Is...

inconsistent rgb/rgba behavior

14

I see different maximum values depending on requested decoding format. decode to CFHD_PIXEL_FORMAT_BGRA: result: r/g/b/a = 0xFF as expected decode to CFHD_PIXEL_FORMAT_R210: result: r/g/b = **0x3FC** (expected 0x3FF) decode to...

encoding small frame from v210 fails

4

64 * 64 -> file with artifacts, or crashing vfw decoder. also tried 96 * 64 [s64.zip](https://github.com/gopro/cineform-sdk/files/1555954/s64.zip)

multi-threaded encoder generates different output than single-threaded

1

I noticed some pattern, therefore looks suspicious. Encoding constant input (repeated still frame) single-threaded encoder output: A,B,C,C,C,... multi-threaded (2 threads): A,A,B,B,C,C,C,... multi-threaded (4 threads): A,A,A,A,B,B,B,B,C,C,C,... So is the output affected...