Shawn McKnight

Results 37 comments of Shawn McKnight

There is some prior art for this in [babel-plugin-module-resolver](https://github.com/tleunen/babel-plugin-module-resolver). [Doc reference](https://github.com/tleunen/babel-plugin-module-resolver/blob/master/DOCS.md#transformfunctions)

@AndreMaz yes, I believe that issue should be fixed by the referenced PR.

> @AndreMaz I go reinstall and try, but the [moleculerjs/moleculer#980](https://github.com/moleculerjs/moleculer/pull/980) not resolve it I'm guessing that moleculerjs/moleculer#980 isn't working here because the `tsconfig` in this repo doesn't appear to have...

I think the type is correct as it is currently defined. In looking at the [retry middleware](https://github.com/moleculerjs/moleculer/blob/1578a8496237042710c3b4b4bc1db0db57ad6261/src/middlewares/retry.js#L20), the expectation is that _any_ error could be passed to the check function,...

> Ok, so how do I get past the error in the broker.config.ts? That was generated by the template. Should the template be changed to define the proper error function?...

In looking at [service.js](https://github.com/moleculerjs/moleculer-apollo-server/blob/master/src/service.js#L23) it appears that you can pass a `schema` property to the mixin. With that said, in looking through the remaining code, I don't see anything actually...

Note: There is a hole here in that Apollo Federation does not currently support subscriptions ([LINK](https://www.apollographql.com/docs/federation/#architecture)): >Apollo Federation does not currently support GraphQL subscription operations. To implement federation using Apollo...

@mabc224 @palpinter Can either of you provide any more information on your scenario where this is undefined? I'm running the local subscription example and its defined and working properly.

I think the issue here is that `this.graphqlHandler` is an async function. By returning without awaiting the catch block for `this.sendError` gets bypassed. I think this is fixed with `return...

I'm wondering if the changes I've recommended in #73 would alleviate the need to override the `subscriptions` property at all. Since the construction of the parameters would largely be falling...