Sam Harwell

Results 738 comments of Sam Harwell

We found this issue during our work to update dotnet/roslyn from v1 to v2.

@ericsink I believe that is a reasonable claim to make. The only remaining question is whether the `sqlite3_blob` is _usable_ while the connection is in the zombie state.

@sebastienros That's a separate issue. `hook_handle.ForDispose()` prevents instances created to represent null from getting disposed. The solution is to delete `hook_handle.ForDispose()` since it's unnecessary (disposing of a null/invalid `SafeHandle` is...

If you try to tackle this and get stuck on some part, let me know and I'll find a domain expert to help. Note that SQLitePCL.raw and other managed binaries...

The extender strategy won't work for SDK-style projects. For ANTLR, I had the benefit that I only wanted to extend my own item type(s), so I was able to implement...

> Roslyn isn't a compiler though It definitely is.

The real answer to this is https://github.com/antlr/antlr4/issues/2428#issuecomment-454751620. ANTLR 3 tried to make ASTs using the grammar, but they just ended up as partial-fidelity parse trees that took longer to create...

It may be beneficial during this to pre-populate missing edges of the DFA states appearing at the k=1 (and maybe even k=2) positions of decisions. Main reason this never made...

I'm going to defer this issue for now, since I'm not confident how I want to handle it and other issues are consuming our time leading up to the 4.1...

@JitCompiler Actually it's a bit different. Since users can modify tree nodes arbitrarily with new fields, it's not safe to claim that this type is serializable. Any solution would be...