Sharan Yalburgi
Sharan Yalburgi
> What if the system is a subsystem of a larger system? Then the state indices can be anything and this might be silently wrong? Fair point. If we can...
- Solving this doesn't seem to be sufficient to make `HCubatureJL()` typestable. See https://github.com/JuliaMath/HCubature.jl/issues/42
@devmotion do you think it is okay to merge this or do you suggest any other changes?
> What is the motivation for introducing `moinput`? It seems in contrast to `mooutput` there is no alternative implemented that doesn't return a `MOInput` instance? I wanted it to be...
@devmotion @willtebbutt Is this okay to merge?
From a quick look, these seem to be the missing kernels (Checked implies that a PR has been created. - [x] covCos - **Note: Output Restricted to [-1,1]. To be...
@theogf @willtebbutt Do you suggest I make separate PRs for each kernel or just one for all of them combined? I suggest we make separate PRs so we can incrementally...
Yeah. The function names aren't the most helpful. I have added a short description to them. Hope that helps.
The `NaN` values in the Zygote gradient seem to be caused by the the `pairwise(Euclidean(), x, y)`. I am not sure why this is happening.
> Can you try the Zygote master branch locally? Maybe it was fixed by [FluxML/Zygote.jl#787](https://github.com/FluxML/Zygote.jl/pull/787). Thanks! The Zygote and ForwardDiff tests pass on Zygote#master. However, ReverseDiff fails, probably requires nan...