shanretoo
shanretoo
I am willing to help with this task.
Thanks for your update! I'll work on the tests.
FYI, my work is in: https://github.com/shanretoo/datafusion/tree/feat-window-fn
@timsaucer I have fixed the calls of `expr::WindowFunction` to meet the changes and add tests for those window functions in `dataframe_functions.rs`. Let me know if I missed anything.
You can check it in the unit test: [`test_fn_lead`](https://github.com/shanretoo/datafusion/blob/65a8895d948152845dda1934b404399919ebe23c/datafusion/core/tests/dataframe/dataframe_functions.rs#L1207).
Sorry, my fault. I haven't taken into account the ordering issue. Maybe we could add a following match arm in the macro to omit the `order_by` parameter and add the...
Have you checked tests in [sqllogictest](https://github.com/apache/datafusion/blob/main/datafusion/sqllogictest/test_files/window.slt)? If we want to make sure all the variants work as expected, I think we should add those tests in sqllogictest. And for the...
Looks good. It is clearer to understand the results in this way.
Also, the `description` property is missing in the doc.
Sure, I'll draft a pr.