XiongDa

Results 19 comments of XiongDa

Hi @riversand963, you may be familiar with this.

> I have tested and confirmed that this is an issue. The fix works and can speed up migration by 10-100 times.Looking forward to your PR More than 10 times?...

l did an incomplete test. For 1 millon times short range query, the query time is reduced more than 20%.

https://github.com/apache/incubator-kvrocks/pull/508 shows the usage of prefix extractor (FixedPrefixTransform provided by Rocksdb) @git-hulk.

> @shangxiaoxiong So I think we can merge what #508 does into this PR and use the new prefix extractor. l think so and l can merge https://github.com/apache/incubator-kvrocks/pull/508 if there...

> Thank you for your contribution, it would be better if you could explain it in detail in this PR, which can help us to see the code and understand...

> @caipengbo is right, we can add more informations to make this easier to review. ha ha ha ! On the way.

> @shangxiaoxiong You can help to pull the @ShooterIT's PR into this, then we can pull others to have a look again. OK

There may be some problem. The Get interface may aim to get the latest expire time of the key.

During sending snapshot, exipre time of some key may be changed to larger by clients. GetMetaData is needed to deal with this case.