shamaton
shamaton
Hi. I don't understand the intention of the PR, but I thought that if you want io.EOF, you should convert it when a decoding error happens. see below. ```go //...
I'm sorry for delay! Have you already solved this issue? If not so, do you call `msgpack.AddExtCoder` in your code?
Yes. You should return the total byte size that the struct is encoded to msgpack format. see also: https://github.com/msgpack/msgpack/blob/master/spec.md#ext-format-family
Any comments or reviews from aws staff?
@miparnisari > Question: since there is no way of testing DAX locally, has this PR been tested against an actual DAX cluster? Yes. I created a validation repository to confirm...
Hi, is status reviewing now?
Hi. Why don't you use ext format? Do you know how to use it? It seems like that we can encode the same as `time.Time`.
Here is examples. https://github.com/shamaton/msgpack/blob/master/time/decode.go https://github.com/shamaton/msgpack/blob/master/time/encode.go You implement your custom encoder and then call `AddExtCoder` when you start your service. ```go msgpack.AddExtCoder(encoder, decoder) ```
Added comment in https://github.com/shamaton/msgpack/pull/48/commits/5fd37375532e3875ad440741cabb6d86bcc2bfce
I’m sorry but I’m not a maintainer this repository. I have no idea about this fix.