Shahar Kedar

Results 14 comments of Shahar Kedar

We're open to PR.

No. This is not support at the moment.

I would like to note that this also results in incorrect parsing behaviour. The following code will run without errors even though `value` is a required preoprty: ``` const Success...

I would like to suggest a above PR (https://github.com/colinhacks/zod/pull/3314) as a possible solution for this issue. We could create a similar implementation for refinement as well.

The root cause for this behaviour are these lines of code: https://github.com/colinhacks/zod/blob/02699107616f672d79d3d71557456ec55597a4fa/src/types.ts#L2853-L2855 The problem is - I just can't figure out why we're checking the dirty state at this point...

> I, for one, find it incredibly useful to enable both sync and async usage of electrolyte for situations in which one is restricted by an existing synchronous API. @patrickhulce...

Ok. On Mac OS it doesn't reproduce. I'll try to run it on Ubuntu. On Tue, Feb 9, 2016 at 10:17 AM ShubertYuval [email protected] wrote: > Ubuntu. > > —...

Huh... interesting. Are you using nvm? On Tue, Feb 9, 2016 at 11:18 AM ShubertYuval [email protected] wrote: > Thanks, how ever node version is - v5.5.0 > > — >...

@minademian 1. Yes it should. I need to rebase with the version that you changed to. We should probably open a separate PR for upgrading the Node.JS version in Travis....