Sun Guangda comments

Results 11 comments of


                                            Sun Guangda

Run test by simulating

Thanks for the detailed reviewing and comments! I am glad to have such valuable feedback for this quick and dirty hack ^^ For the intuition of helping students let me...

Run test by simulating

The deterministic simulated mode for run test is finally done and ready for use. (Will call it "replayable mode" for short.) Since it has been some time since this pull...

Run test by simulating

Seems like `nextLong(a, b)` is only added in Java 17 and I was developing on Java 19. (But I still expect compiler to reject such backward-incompitable code.) Will fix soon.

Updated time model benchmark |Test |`-g FINER 2> /dev/null`|`--simulated` | |-------------------------------|-----------------------|---------------| |`--lab 1 --part 3 --test 6` |210202 |299932 | |`--lab 2 --part 2 --test 14` |117130 |78805 | |`--lab...

`clippy::mut_mutex_lock` after an immutable reference is held

+1 when writing `impl &'_ Mutex {...}` block

Update Rust images to use `default` rustup profile

@microsoft-github-policy-service agree

Update Rust images to use `default` rustup profile

Firstly I admit that the description above exaggerated the problem for a bit. Currently with a freshly set up devcontainer, the linting and formatting tools are actually available. (Guess that's...

Update Rust images to use `default` rustup profile

I have just checked the upstream dockerfile and the feature script. I admit to not being the one most familiar of the both, but in my opinion they match each...

Rustfmt duplicate associated type bound in the presence of comment

Ah did not realize there's a dedicated repo for rustfmt, sorry for that>

Semantic violation that involves rendezvous channel and selector

Thanks for pointing out the mistake. I admit that that was a mistake during minimize the reproducing code. Here is a slightly involved version: ```rust fn main() { let ch0...