Silviu-Ioan Filip

Results 6 comments of Silviu-Ioan Filip

Sure. Go ahead. I'm happy with exposing more useful functionality. I will hold off on reviewing this PR if you want to continue with changes in this branch.

Regarding the "point bands" code, this is something that I added in as it is also supported by the Matlab implementation of firpm. I admit that this is the only...

Hi! Not really sure what to answer. Haven't considered building a Python interface to the tool until now. You're welcome to try something out. When I have some time, I'll...

Hi @gsmecher! I'm open to changes and would happily accept any PR that makes the library easier to use and/or offers more flexibility to the end user. Regarding the construction...

Comments on @ev-br's notes. - No problem in disabling OpenMP. Threading can be added later if the performance gains are deemed sufficiently interesting. - Using LAPACK directly looks like the...

The initialization strategies are somewhat complementary. A good default is to start with the classic one. The way it is implemented in `firpm` is through an optional parameter, as you...