SeungYoung Oh comments

Results 6 comments of


                                            SeungYoung Oh

react/error-declarative-handling-1/

안녕하세요. 좋은 글 감사합니다. 선언적인 비동기 처리를 적용해보면서 고민됐던 지점이 있어 댓글 남깁니다. 컴포넌트에 필요한 데이터를 패치하는 경우에는 선언적으로 코드를 짜기 좋았는데요. 몇몇 경우 불필요하거나, 어렵다고 느낄 때가 있었어요. 예를...

[ZEPPELIN-6142] Apply synchronizer token pattern to terminal interpreter for CSWSH protection

@tbonelee Thank you for the review. I’m going to give some more thought to the CSRF token theft issue that you mentioned, and add a commit for it.

[ZEPPELIN-6366] Separate WebSocket max message size into a dedicated REST API

@Reamer In this case I applied it to both, as you mentioned, to make it easier to remove unreferenced things later on. But I don’t think we need to do...

[ZEPPELIN-6340] Add ZeppelinEventBus and update NotebookServer to handle NoteRemoveEvent

I've done it. Thanks. @tbonelee

[ZEPPELIN-6340] Add ZeppelinEventBus and update NotebookServer to handle NoteRemoveEvent

@dididy The changes in this PR branch don’t conflict with master, so the empty merge commit seems natural. The CI(core.yaml) failure is probably caused by the changes in this PR....

[ZEPPELIN-6312] Remove configuration WS usage in frontend

I’ve updated according to the review comments. But I found one issue: the configurations WS API has no auth check, while the REST API does. So users without permission can...