Sergio Álvarez

Results 9 comments of Sergio Álvarez

Hi, @sualko! Thanks for taking the time to open this issue and explain your findings :-) I'd be open to exploring this since it may help us with #9.

Hey @sanny-io, thanks for contributing! Would you mind adding a test case for this change?

Hi, @Allen-Hu! Currently, any operation that modifies the request's `body` (or `query`, `headers`) is not supported. We use `joi` to perform validation only. Anyway, I think you raise a valid...

Hi, @JeffreySoriano5! That's currently not possible, but it looks like a good idea to me :-) I will take a look at joi's documentation and hapi implementation to see if...

Another thing to consider: as a TypeScript user, I would expect `req.query` or `req.body` to match the defined Joi schema -once the request gets converted. I don't know if that's...

Hi Klaus, I still need to find some spare time to review this. At first glance, it looks good, but I can tell you I won't approve the PR until...

It's happening the same for `nuxt generate` but, in this case, it does not even work with `window.google` instead of `this.$google`.

Hi @rezrah, > I'm checking that this isn't blocking you right now? No problem. We have changed the code a bit, so we only set `aria-current="page"` for the current item.

Adding one more example. The `River` component ensures some outer spacing, but `Testimonial` and `FAQ` components do not work well together without additional CSS: ![Screenshot 2023-05-16 at 11 00 02](https://github.com/primer/brand/assets/3042654/5feb7859-939c-45df-88be-39f3760f05c5)