Serge Petrenko

@Gerold103 thanks for the review! I've addressed most of your comments and will return to the remaining ones tomorrow. Also reworded the commit message: > From the commit message: "this...

Checkpatch still fails complaining about result files for some reason.

> There is a new rule in checkpatch that prevents new diff tests appearance. Although, there was an https://github.com/tarantool/checkpatch/issues/35 and a fix is already in the checkpatch master. Perhaps you...

@Gerold103, I've adressed all your comments. Please, take a look.

I've made some changes to the last commit after a self-review: diff ```diff diff --git a/src/box/box.cc b/src/box/box.cc index 46333d95e..ff0d72968 100644 --- a/src/box/box.cc +++ b/src/box/box.cc @@ -1819,6 +1819,8 @@ struct sync_trigger_data...

I've found a bug: my implementation only waited until the transaction, which might be confirmed, reaches the node. But it didn't wait until this transaction is actually confirmed. Which is...

It's not necessary for a trigger to clear another trigger to crash. For example, a trigger may yield (this is allowed, I believe?) and while it yields some other code...

We encountered this issue while working on #6126. Reopening.

@Gerold103 PTAL

Checkpatch fails with the following error: ``` Commit 6c2d50ed1b29 ("core: replace trigger initializers with trigger_create() calls") -------------------------------------------------------------------------------------- ERROR:UNCOMMENTED_DEFINITION: 'vy_set_deferred_delete_trigger' definition without comment #247: FILE: src/box/vinyl.c:4564: +vy_set_deferred_delete_trigger(void) total: 1 errors, 228...