Selim Ok comments

Results 11 comments of


                                            Selim Ok

Add ignoreExpiry(), ignoreNotBefore() and ignoreSignature() to JwtPa…

Hi, are there any decision to merge this change into master? As part of our token expiration strategy, we create tokens with short life spans and re-create new tokens if...

Add ignore validation options and static methods for validation of claims independent to token parsing

Ok, i will give a try. Thanks. And sorry for the test coverage :(

Add ignore validation options and static methods for validation of claims independent to token parsing

Do you have an idea how can fix that https://coveralls.io/jobs/18754160/source_files/1580589642#L15 ? Thanks.

Add ignore validation options and static methods for validation of claims independent to token parsing

Hi @lhazlewood, can you please check my changes again. Thx. :)

Add ignore validation options and static methods for validation of claims independent to token parsing

Any decisions?

Add ignore validation options and static methods for validation of claims independent to token parsing

Are there anything else that I can do for a PR acceptance?

Add ignore validation options and static methods for validation of claims independent to token parsing

If my PR less likely to be accepted, I would open a new feature request for setting clock skew seperately for notBefore and expiry claims. So that I can at...

Add ignore validation options and static methods for validation of claims independent to token parsing

Hi @lhazlewood, no problem. Sorry for my impatience. Thanks in advance for your effort.

Deserialization should throw error if wrapper tag name is wrong

Hi, Same problem here. I expect the root element name (either using the class name or localName attribute of @JacksonXmlRootElement annotation) is considered while deserialization and in case of non-matching...

`You should use slots` when using components and json files

Same problem here after changing to @nuxt/content-edge version 2.1.0-27661776.91d257e. Steps to reproduce: - ssr: false - npm run generate - npm run preview There is no problem while testing with...