Michael Duggan

Results 9 comments of Michael Duggan

Most of these warnings should be able to be fixed by adding a user-defined copy-constructor for `PlTerm`. It's basically complaining that, since you have defined a non-default `operator=(const PlTerm &)`,...

Just to be complete, I can think of at least four ways we could legitimately end up with two things that look like constructors for the same object with identical...

Is the fact that ordinary copper cables do not trigger the crash relevant at all?

Well, I haven't tried it with yaml-cpp, but I have had to deal with this problem before. Here's a snippet from that: ```cmake find_package(date CONFIG NAMES date howardhinnant-date REQUIRED) message(STATUS...

Looks like there's a missing `!` in that line before the dynamic_cast.

In `libpharos/funcs.cpp:1216`, we're using a ROSE `AstMatching` expression to match an `SgNode` expression. This is what is failing. My initial perusal of ROSE's `AstMatching` code finds that it is matching...

This is an untested modification to ROSE that *might* solve the problem. I'd want to recreate the problem to test it before submitting it upstream. ```diff 2 files changed, 4...

Good catch. So we should throw a static mutex around the `AstMatcher` creation.

I just pushed a new branch, [pichash-work](https://github.com/cmu-sei/pharos/tree/pichash-work), that should not have this issue. This branch does have extensive changes to the PIC hashing output and is not guaranteed to give...