Olusegun Akintayo
Olusegun Akintayo
Work done so far. I have removed all the UI related code in constant and moved them to shared/ folder. The rationale for this is that the code are being...
> Code changes look great, 2 feedbacks: > > 1. Can you plz check possibility of using global scope as discussed > 2. Will be nice to have text coverage...
can we have more information in the description? especially the before and after screenshots.
Hi @seaona yeah, I saw that too...it's from another PR and not this one. We can open another ticket to fix that.
Looks good, but the e2e needs to be fixed.
@danjm merged a PR that fixes the issues in this PR, @bschorchit @jpuri confirm it's okay to close this issue?
This PR also fixes https://app.zenhub.com/workspaces/-confirmations-secure-ux-6245e6e2348677001213b8d2/issues/gh/metamask/metamask-mobile/8797
My work on the [flashing gas fees after MV3 restart](https://github.com/MetaMask/metamask-extension/issues/16456) brought me back here. I noticed that even though `store` retains the values of all specified controllers, `memstore` only retains...
The fix for this (thanks to @Gudahtt) is to set initialState in GasFeeController. I also took a look at all the controllers and these 3 controllers don't have initial state...
Can you fix the conflicts?