Scott Determan
Scott Determan
@scottschurr Fixed comments in: 06ea306092 [fold] Reword some comments
@ximinez I just pushed a patch that might fix the boost 1.77 errors, can you try this ( [[fold] Fixes for visual studio: shared_ptr unique and type_traits](https://github.com/ripple/rippled/pull/4206/commits/a4db876306105a3a7599276d6673f7cd2288808c)
@ximinez Can you try it now? I replaced the `result_of` with `invoke_result`. (This patch: 3ef203daea [fold] Replace result_of with invoke_result)
Squashed and reworded. Not marking as passed until we get the docs updated.
@ximinez Added a patch that should fix the enum issue. Also rebased onto the latest develop. Can you retest when you get a chance?
Squashing and marking this as passed
Thanks for resubmitting the PR. I'll try to get to this later this week. Edit: Sorry, I don't have time to get to this right now. But rather than let...
@nbougalis Re: catching the exception (I wish github would let us respond to top level comments): That's a reasonable position - my real concern was putting this behavior change in...
@scottschurr I'd love to have the word `wait` in the name somewhere - or something that implies that this function can sleep.
@scottschurr I'm fine with either of those. It's hard to name this function because it does two things - it waits for a condition and it returns if we're stopping....