sebright2

Results 26 comments of sebright2

Question: Why tag value has to be string?

/cc @dinooliva

Tracing: Consider adding a flush API.

Related: https://github.com/census-instrumentation/opencensus-java/pull/1141

Decide the scope of data collection

> My question is whether we want exporter-specific registration, assuming the user has control of which views to export in aggregate. This issue came up in opencensus-java. We wanted to...

Move current Span logic from the API to the implementation.

I merged #643, which applies this change to tagging.

Move current Span logic from the API to the implementation.

Unassigning, since I'm not currently working on this issue.

Provide a way to override the traceId/spanId/sampled keys in opencensus-contrib-log-correlation-log4j

This feature is still needed for overriding the default key names when they conflict with keys added by other libraries, or for purposefully using the same keys as other libraries....

Consider providing Java annotations to automatically add tags or start a child span.

/cc @dinooliva

Add code examples to the 'tags' package.

See https://github.com/census-instrumentation/opencensus-java/pull/485#pullrequestreview-53065563 for more suggestions on documentation for tags.

Add code examples to the 'tags' package.

This issue is for adding examples to Javadocs in package-info.java and classes like TagContextBuilder or Tagger.

Add code examples to the 'tags' package.

This issue is about improving the Javadocs for the tagging, for example, TagContextBuilder and Tagger. I think the examples can be much simpler now that there aren't multiple key types,...