Seb Ferrer

Results 12 comments of Seb Ferrer

> Some checks were not successful > > > CDS/UXMAN-manager-build-v3 — build-v3: Fail > > Could you please rebase on `develop` branch? Done, but the check still seems to not...

> Will look into these: https://samltest.id https://www.samltool.com https://mocksaml.com https://stackoverflow.com/questions/1125915/can-you-recommend-a-saml-2-0-identity-provider-for-test We used a lot samltest.id and samltool, I recommend these :)

Good news, this PR is ready for review! We will soon take into account the first feedbacks and then take care of the missing tests. Thank you!

Hey @splaunov Some changes are necessary in your PR following the reorganization of our part of the code, please take a look at it! :) https://github.com/ovh/kratos/pull/4#pullrequestreview-1145379698

> Will there be a follow up PR to support SAML in oathkeeper? @batmilkyway This is unfortunately not planned on our side at the moment.

> Awesome, thank you for working on this feature! There is a couple of topics I'd like to address, please see my comments. Thanks! :) Hey, I think we've taken...

> Hello @sebferrer, there is conflict to resolve, can you take a look please? Rebase done

Hey @aeneasr, small update: we added unit tests to cover our continuity manager based on RelayState (essential to the SAML flow, more information here https://github.com/ory/kratos/discussions/2486). Feel free to have a...

@aeneasr thanks a lot for your help! You should have access to push on ovh/kratos now :)

Hey @aeneasr! I think all your last reviews have been taken into account, we did a refactoring of the continuity manager in the case of using RelayState. Feel free to...