Sean Mailander comments

Results 5 comments of


                                            Sean Mailander

Out-of-order commits on different PRs result in skipped builds

With some hack-n-slash debugging, managed to capture the following debug statement ``` 2018/06/07 21:19:29 check failed: skipping PR: 1488 953b8f2b9622a34d4bec2e75aab663f414ff30ab 2018-06-07 21:18:57 +0000 UTC < 2018-06-07 21:18:57 +0000 UTC ```...

Out-of-order commits on different PRs result in skipped builds

Agreed, the evidence I'm seeing all points to behaves-as-expected given the timestamps and order of operations For our use case, we would be fine with latest-commit-for-each-PR as the array of...

Out-of-order commits on different PRs result in skipped builds

Ah, I think I understand now how this _could_ work with out-of-order commits ### Add an extra field to each `version` object: **1.1** Add `alreadySeen`: a string-encoded array of key-value...

Out-of-order commits on different PRs result in skipped builds

Testing with a release candidate of #28, seeing every commit trigger a build regardless of order of submission. Concourse looks happy, even though the `alreadyseen` field is pretty gnarly in...

Out-of-order commits on different PRs result in skipped builds

No worries, happy to contribute! If the resource always emits the latest commit for all PRs, what sort order is chosen? This is not a quote, but my understanding of...