Sean Kao

Results 10 comments of Sean Kao

When running `DESCRIBE TABLES LIKE opensearch_dashboards_sample_data_flights COLUMNS LIKE "time%"`, the result is correct. Without the quote around time%, this line throws an exception https://github.com/opensearch-project/sql/blob/127b6627f380272da48c21705224802d1b717862/legacy/src/main/java/org/opensearch/sql/legacy/plugin/RestSQLQueryAction.java#L106 ``` org.opensearch.sql.common.antlr.SyntaxCheckException: Failed to parse query...

This error comes from the use of keyword as part of the string literal. Do we actually want to "fix" that? Or do we want to leave it as it...

## Design ### OpenSearch Request #### Request Operators ##### Non Aggregation Query Interface to the OpenSearch engine used by the `OpenSearchIndexScan` physical plan 1. `OpenSearchQueryRequest` The default request operator. 2....

Remaining issues: 1. Extend query size limit for aggregation query requests 2. Described as follows Here we assume ``` query.size_limit = 200 index.max_result_window = 10000 ``` These work as expected:...

One note on the performance. With this feature, there's no limitation on the size of the query result anymore, so it's possible that a single request-response cycle take too long...

# [Draft] Design Doc ## 1 Overview Support pagination requests for PPL and SQL query ## 2 Problem Statements The V2 engine limits the response size of a query. This...

> In the second cursor request can there be a scenario with some extra calculations along with push down. how do you retain entire physical plan? Thanks for pointing this...

I think it’s intended that DROP want to delete indexes of all those states. What’s not intended is that it was assuming the job to be either streaming job or...

Before refactoring the DML handler and FlintIndexOp, DROP index involved 2 steps: Cancel op and Delete op, and each has their own validation. ([cancel](https://github.com/opensearch-project/sql/blob/60058ce1de6db0c6c2278a2382b674ff6e1eb78c/spark/src/main/java/org/opensearch/sql/spark/flint/operation/FlintIndexOpCancel.java), [delete](https://github.com/opensearch-project/sql/blob/60058ce1de6db0c6c2278a2382b674ff6e1eb78c/spark/src/main/java/org/opensearch/sql/spark/flint/operation/FlintIndexOpDelete.java)) After refactoring, the two steps...

@LantaoJin could you check whether this will be supported with the Calcite work