Sean Eagan

Results 76 comments of Sean Eagan

it doesn't seem like recursive will work, since the "direct" dependency update will pull in its own recursive nested packages anyway. what does seem useful to me is a single...

On the other hand, if there are multiple changes, e.g. a ConfigMap, Secret, and HelmRelease, wouldn't this lead to multiple quick fire new release revisions, as the operator reacts to...

:+1: , added #454 for configuration of rollbacks/uninstalls on test failures

Deleting releases is dangerous, since e.g. changing the `relesaeName` could be accidental. Maybe an error could be thrown by checking the `status` object and seeing that there is already an...

#453 should accomplish the same goal (manually triggering upgrades), but in a more declarative and operator-driven way.

#447 addresses the rollback count reset TODO

That makese sense, since time coordination between between client and server may not be reliable.

Also updated the proposal to use `syncAt` after all since the whole sync process is triggered (including tests if enabled).

3. should follow how it's done in the other toolkit components: https://github.com/fluxcd/source-controller/blob/b078847ce8c87a412c5798fc32faabcc2d7eb58c/api/v1alpha1/condition_types.go#L55 https://github.com/fluxcd/kustomize-controller/blob/81e077811f3ed09275a8eb5a063fd8c3b61e6bc1/api/v1alpha1/condition_types.go#L56