Serge Titov
Serge Titov
@davidshimjs, could you please merge it, or reject, or smth else.
correct code, that supports cyrillic & emojy would look like this: ```js function utf32to8 (str) { var out, i, len, c; out = ""; len = str.length; var codeAt =...
It seems to be a mistype here https://github.com/mazenrashed/Printooth/blob/5674058107b1936e3bcfb52d3f925635c9481ea5/printooth/src/main/java/com/mazenrashed/printooth/data/printer/DefaultPrinter.kt#L54 @mazenrashed CHARCODE_PC866 should be 17 decimal or 0x11, not 0x12 https://reference.epson-biz.com/modules/ref_escpos/index.php?content_id=32
This PR seems to break Polyline.closestLayerPoint, adding new edge between last and first point, and even for a Polygon this shouldn't work when clipping occures. I'd try to construct polygon...
I agree about docs, @Falke-Design. Probably the only aspect where current design is better -- it's much faster for large geometries like countries' borders.
Thought for a while: if you decide to rewrite closestLayerPoint from _parts to _rings, could you please return not only point and distance, but also ring's index, and point's index...
Fix, that worked for me. Inspired by L.Polyline.closestLayerPoint ```javascript L.Polygon.prototype.closestLayerPoint = function(p) { let minPoint = L.Polyline.prototype.closestLayerPoint.call(this, p); let minDistance = minPoint ? minPoint.distance * minPoint.distance : Infinity; const closest...
Fix it? Sorry, i don't understand your question :( (or does "to work on" have other meanings except "to influence"?)
Sorry, @MadhukarRagaji, your fix is a no go. It ruins correct behaviour of a polyline's closestLayerPoint in favour of highly likely incorrect behaviour of a polygon's closestLayerPoint. There's a difference...
See my comments on reproducing clipping errors below your pr.