John Zhang

Results 6 comments of John Zhang

Here is an easy one. There are alerts. 5 for Unused variable, import, function or class

The edit link looks good. But I feel the refactor of containsData should be in a separate PR. I agree containsData is overly complex. It's overly complex because it's too...

> > The edit link looks good. > > But I feel the refactor of containsData should be in a separate PR. > > I agree containsData is overly complex....

I am the memory expert in java, so if nobody longing to work on this. I will pick this up. See I can put my java knowledge to work.

It only has 15 pages. I tried to reproduce the problem as much as I can. But I can't reproduce it. Not only I can't reproduce it. the pdf was...

The overall size is not a problem, it can generate pdf into 100s pages. The problem is that no text field can be larger than 10K.