Scott Schurr

Results 10 issues of Scott Schurr

## High Level Overview of Change Fixes [#4005](https://github.com/ripple/rippled/issues/4005) Makes it possible for internal RPC Error Codes to associate themselves with a non-OK (200) HTTP status code. This commit also adds...

## High Level Overview of Change Fixes https://github.com/ripple/rippled/issues/4115 ### Context of Change @mDuo13 noted: > It's confusing and unintuitive to see an "immediate or cancel" transaction treated as "successful" when...

### Context of Change A recent change modified the name of a member function from `SHAMapStoreImp::health()` to `SHAMapStoreImp::stopping()`. Personally, I find the name change to `stopping()` misleads me when I...

## High Level Overview of Change The goal of this amendment is to curtail the occurrence of order books that are blocked by reduced offers. This commit identifies three ways...

## High Level Overview of Change It turns out that the feature enabled by the `tfTrustLine` flag on an `NFTokenMint` transaction could be used as a means to attack the...

## High Level Overview of Change Up to this point the server's internal code has presented every ledger object type to programmers as a - `std::shared_ptr` or as a -...

## High Level Overview of Change While reviewing a different pull request I noted that the code coverage of memos is not as good as it could be. So I...

## High Level Overview of Change While reviewing other code I stumbled across a number of constants defined in resource/Fees.h that are unused anywhere in the code base. They did...

Low Priority

## Issue Description A trust line is removed from the ledger unexpectedly. ## Steps to Reproduce The following unit test member function reproduces the problem. ``` void testTrustLineWithOnlySetfAuthIsRemoved() { testcase("Trust...

Good First Issue
Bug
Amendment

## High Level Overview of Change It was discovered that there are a couple of NFT directories on the MainNet that are missing links in the middle of the chain....

Amendment
Perf impact not expected