Ahmed Tawfeeq

Results 10 comments of Ahmed Tawfeeq

> Hey @scorpion9979, just to clarify is the idea here that the inheritdoc would become a link of some sort, or that we swap in the documentation inline? Yes, the...

Is this planned to be worked on, or can we close it?

I'm a developer and I could possibly do the integration myself if you guys point me in the right direction.

Thanks, @kroitor. I've just learned that CoinZoom only offers the trading price data through its WebSocket API. Is there a way to integrate the WebSocket methods properly? https://api-docs.coinzoom.com/#streaming-websocket

I was looking into this myself. By performing a [quick search on GitHub](https://github.com/search?q=path%3A*.sol%20%22%23region%22%20%22%23endregion%22&type=code), we could see all Solidity code out there that integrate region comments. Also note that this feature...

I think this is a very necessary feature. Currently, there is no way to set the amount of ETH to send as the msg value for a payable function.

Ideally ERC4626Hook should be defined as an abstract contract, but I wasn't sure what's the desired convention for testing an abstract contract in this repo.

> Overall this PR looks interesting and combining a hook with ERC4626 opens many interesting use cases. However, could you explain the exact use case for when this hook would...

> > Ideally ERC4626Hook should be defined as an abstract contract, but I wasn't sure what's the desired convention for testing an abstract contract in this repo. > > Why...

@alexfertel That sounds good. I felt this should still be documented somewhere as I occasionally had to run this particular search and replacement. Also, you're right regarding the simplified regex....