Szymon Cofalik

Results 77 comments of Szymon Cofalik

I see that you requested a review but only changed the place where the fix is applied. I wrote a response regarding refactoring `WidgetResize` and `Resizer` and how they communicate....

Regarding your previous post: 1. Please create an issue to improve current solution. Title: "`insertContent()` should not depend on affected range when inserting markers". 2. I think this happens because...

What about a case where marker starts in filtered content but ends in non-filtered content (and vice versa)?

@arkflpc Could you look at it from TS perspective?

There's also text-indent property: https://www.w3schools.com/cssref/pr_text_text-indent.asp

Maybe I don't see something but... why not set it as one of options when creating `ClassicEditorUIView` instance? ``` const view = new ClassicEditorUIView( this.locale, this.editing.view, { shouldToolbarGroupWhenFull, label: this.config.get(...

Does this have any impact on multi root editor implementations that people have? I mean changing how the view is set?

Interesting subject. If you need to, for now, you can workaround this by using `afterInit()` method of `Plugin`. `afterInit()`s are called after all `init()` calls are done. So, at this...

> For the given use-case, such an extra event would help. But plugins should not register more elements at this stage, they should only be allowed to extend existing registered...

Hello, just letting you know that we looked at the issue and found a potential problem. We will update you when there's progress with this problem.