Sara Dolganov comments

Results 11 comments of


                                            Sara Dolganov

Many seems to be broken

Hi. Can you describe what exactly you are expecting from your code? Maybe you have more meaningful example. I don't understand what do you think is broken...

Many seems to be broken

OK, now I see. I think map + flatten is right solution. @tomstuart, what about you?

Fixing the Many monad, respecting the specs

That's seems like right solution. But I think your tests are not very obvious.

Fixing the Many monad, respecting the specs

cool. :ok_hand: @tomstuart ?

Fixing the Many monad, respecting the specs

I agree that `.flatten(2)` is incidential hack. I have some ideas why. Want to test, prove them and then share about success...

Fixing the Many monad, respecting the specs

It's seems like `Array(value)` is not right solution due to problems with changing input object. Because `Array(...)` is calling `#to_ary` method, that could mess up input object. ``` ruby Array({a:...

Fixing the Many monad, respecting the specs

Hmm. I checked it again. With `#each` we also have problems: ``` ruby > Monads::Many.from_value({a: 1}) => #1}> > Monads::Many.from_value({a: 1}).keys NoMethodError: undefined method `keys' for [:a, 1]:Array ```

Fixing the Many monad, respecting the specs

So lastly, it seems like we should check type. If current value is an Array, then skip wrapping, and wrap otherwise.

Optional plays nice with Hashie::Mash. Should it play nice with ActionController::Parameters and OpenStruct too?

Hi @olistik can you explain to me why are you using such examples? in my thoughts the valid examples should be: ``` ruby require 'monads' require 'ostruct' require 'action_pack' require...

`precision: nil` added to datetime columns in `schema.rb` in 7.0.2 causes a change in value

We faced related issue on MySQL specifically, if you try to assign default value to a timestamp column: ``` # In migration t.timestamp :foo, precision: 6, null:false, default: -> {...