Sam Jackson
Sam Jackson
@loganlinn @jordangarcia up to you guys what you want to do with this. it'd be a shame to not get this in prod soon as resolves a good chunk of...
@loganlinn A cache abstraction would be nice. Did you have something in mind?
Before I make any changes, I want to make sure I point out the driving motivator of this change, which is that caching as it is currently implemented is broken....
@jordangarcia I like that. Would you be ok with disabling caching for unobserved getters (ie things that are just `flux.evaluate`d)
@jordangarcia So this would include: 1. `alwaysCache`, `skipCache`, and `cacheKey` options for getters, specified via `Getter` constructor 2. Cached values for observed getters are dropped on unobserve (this would help...
@jordangarcia I thought you were advocating for maintaining the cache by default behavior of `reactor.evaluate` (ie caching by default). One flag seems cleaner to me as well
@jordangarcia Updated with the following: 1. `Getter` constructor, with `cache` and `cacheKey` options 2. Removing unobserved values from cache 3. Dropped `getCacheValues` and `clearCacheValues` from `Reactor` 4. default max items...
@jordangarcia one other relevant change, I'm now clearing cache values on `Reactor.reset` as well
@jordangarcia @loganlinn Removed the `Getter` constructor in favor of `Getter` pseudo constructor, modified `removeObserver` to only delete cached getter values if nothing else is observing the getter, or if the...