Hans Schulz
Hans Schulz
I would like to add a slightly different usecase to this FR: Have the snapshotting running all the time according to snapshotting rules (grid etc.) but only replicate at night...
Looks good, but what is the reason behind the `on_signal_wakeup` switch? What would I use the wakeup signal for otherwise?
But why the switch then? The wakeup signal is only triggered manually (or is it?); If I don't want it triggering a replication, why would I send it in the...
This would be great for camera angles you cannot view from outside the printer, especially nozzle cams like this: https://www.youtube.com/watch?v=GAp23w_dnNc
I have already done the EasyCLA process and I'm waiting on the approval of my organization. I'll add integration tests then, thanks!
Hi @pivotal-david-osullivan, I've added integration tests. Could you please run them in your lab? I've also completed the CLA. From my side this PR should be ready to merge, so...
Hi @mheath , Thank you for the review and kind words :slightly_smiling_face: I've addressed the issues, please take a look.
Hi @mheath, I've changed the base branch. It looks like its lagging behind main a few hounded commits. Should I rebase it?
Hello @mheath, do you have any updates on this? What is missing to get it merged to master?
I am experiencing it aswell (Antergos Arch Linux; Cinnamon). Its not specific to CSGO though, the same happens in CSS and TF2, ~~so it looks like a general Source issue.~~...