Sebastian Brandhofer

I looked a bit into this and would like to go for the algorithm in https://www.uni-marburg.de/de/fb12/arbeitsgruppen/algorith/paper/enucon.pdf [1] instead. The work you referenced has a time and space complexity of at...

Thanks for writing this up! I learned a lot while reading this! :-) I will go over your comments tomorrow and sorry for submitting individual comments instead of one batch...

Thanks @jakelishman! Let's discuss the remaining bits in the qiskit-dev meeting and then I think the circuit documentation is good to go. Thanks for writing this up! :-)

`StarPreRouting` works now but depends on #12057 and `FinalizeLayouts` in #9523 being merged (parts of this pass are adapted from #11614 ). If you have any suggestions/comments - I would...

> Thanks @mtreinish and @sbrandhsn for getting this completed, this is definitely going to be a super-useful pass. And thanks @jakelishman for doing this review (somehow I forgot that I...

Thanks for looking at this! :-) I'm somewhat confused. Let's say we have nodes `n={0, 1, 2, 3}` in the same topological level such that any sequence over `n` would...

Should we update the documentation as a short-term solution? I'm also wondering whether we could simply wrap the user input/key in ascii brackets.

Should we update the documentation for now, requiring an user to specify the `key` function such that it always returns a string that is wrapped in `[]` and that string...

Sounds good to me, thanks for that comment! I was a bit worried because of code duplication but I think it makes sense to have a separate function - I...

Sounds good, thanks! :-)