Steven Bosnick

Results 10 comments of Steven Bosnick

One place that does have a case sensitivity issue is in directly parsing a Scheme. For example ```rust let scheme: Scheme = "hTTp".parse().unwrap(); ``` does not canonicalize the "hTTp" to...

If there are any concerns about a possible performance impact I would be happy to add benchmarks to answer that question.

The latest commit removes the performance regression that the benchmarks in `benches/uri.rs` showed (to within the margin of error). This retains the one-loop version of the core parsing code but...

The latest commit improves the performance of this branch to just shy of master. The results that I see on the uri benchmarks are as follows: Master: ``` test uri_parse_relative_medium...

When `http` upgraded the version of `bytes` it uses to 0.5 this also necessitated an increase in the minimum supported version of rustc to 1.39.0 because that is the minimum...

I am part way through the review of the use of `unsafe` (in #408, #410, #413, #414, #416, and #417) so I wanted to provide an update on this issue...

In #419 there is one use of `unsafe` that might, or might not, make it appropriate to change the pubic API of `http`. None of the earlier pull requests involve...

The latest commits (specifically https://github.com/hyperium/http/pull/419/commits/6364f795fb860e959d7133688f2e797be148ae57) make an opinionated change to marking `from_maybe_shared_unchecked` as an `unsafe` function. Specifically it removes the `unsafe` from the function definition. As described in more detail...

This is likely caused by not having listed "libiberty-dev" as an apt package in the addon section of your travis.yml file. See #38 for my explanation for where this comes...

I have implemented a crate to do this: [fd-queue](https://lib.rs/crates/fd-queue) which I am currently trying to upgrade to tokio v0.3. The pre-release published version of the crate works with tokio v0.2.21....