Sreenath Bodagala
Sreenath Bodagala
> The base branch is probably the version vector one? No, it's master.
> ### AWS CodeBuild CI Report > * CodeBuild project: foundationdb-pull-request-build > * Commit ID: [7c91983](https://github.com/apple/foundationdb/commit/7c91983aeaa76e02dab45359a5e7fa53b54226a0) > * Result: SUCCEEDED > * [Build Logs](https://build-logs-034006644693-us-west-2.s3.amazonaws.com/build-logs/foundationdb/foundationdb-pull-request-build/d09b2f93-adf8-4928-b03f-2356a219fa97.gz?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=ASIAQP2XUG7KZMS5L7QE%2F20210706%2Fus-west-2%2Fs3%2Faws4_request&X-Amz-Date=20210706T195613Z&X-Amz-Expires=604800&X-Amz-SignedHeaders=host&X-Amz-Security-Token=IQoJb3JpZ2luX2VjEGQaCXVzLXdlc3QtMiJHMEUCIQCg9e1oU%2Bp1hfCYAQ404SYUVqFc%2BQ3mNV9bW6Lmh3to2QIgJgQ5cgNfrcJOCjIiDT9%2FQ9wcGdNTkhEByzN16KqeX8kqkwIITRAAGgwwMzQwMDY2NDQ2OTMiDLEcZo2IyiV83cK0QSrwAYspXraFLQPV1%2FKjuVXwU2iyQj1xObemCty%2FXM4t7KVj8O2%2BXR47zL8cQT7baWWw7R7dZsPb1RM4%2FwxkS4mMxCtSK1mia56Qkp0dbDBjOW1YUw%2BWqhm7m4qd8YNea28HpYglgIVhmRZzzIfrHaGumKioU32NOZUu%2FppRTRGZqaWfU8CEbFRRqgOWoBXPIMXAPl1YPG7j36tOiIfUjA2FH%2FFFrZoJ5%2F%2BoynOReynXuX39FcVIVGu8Un05S3LBoSXvrfoHQ850kOvStkbmrL1dh18SM%2Bd%2FHXx29cuH821kanFARvFX%2B5jozbHCiLzCGksgBDDc6pKHBjqaAa0bDSetBA6Ej48%2BIclYuEMhJvLVtwIkRTqFVqhpHonk9sJEDqku8LBUtG6XbTJK4QGnsu7mD%2BZRLCwKi0FHFrGHOJxYYKO3LO6QzjYNnP%2Fys2KICg9N3bNMd9yEJtLWOWu59NLTnsR9Dr%2BidUfuspo7oTJOUNIIBkjnulHOr0DJLYwCQy8rmrFFpM6%2FzdyxuORL4xKbRtrHXrg%3D&X-Amz-Signature=dfa79de80fae6bbcbaa2fe8dfcaa3e58806a9827b4409cd75d4741a62fae34ab) (available for 7 days) CodeBuild succeeded....
Any more comments on this PR? Thanks!
I think I messed up here. @jzhou77 / @dlambrig : Do you know of a way to get this diff from GitHub? Thanks!
Ok, I found a way to get this diff. I will apply it over the latest "main" and open another PR. Thanks!
> @sbodagala can you run a correctness for this PR before merging? Ran a correctness test (with 100000 simulation tests). The test run stopped after doing 99994 test runs, at...
Is there any specific benchmark you are planning to use this framework for? (I see that this PR is still in Draft state.)
> What if the buildTeam consistently failed? Has it failed in any simulation test, without the changes in this PR?
> We have serialization problems when using tuples I wrote a unit test that serializes/deserializes a "std::deque" with a single element in it, and that works fine. So there is...
Does this PR handle all (known) race conditions (or, are there any cases that need follow up PRs)? Thanks!