Sebastian Funk
Sebastian Funk
Also the model is fitted separately to the subnational and national data, in each case estimating the smoothness of the curve. Given that the subnational data is probably more noisy...
Other more general things to consider for either this or a future version - Merge `regional_epinow` into `epinow` and allow splitting by any number of covariates (including age etc.) -...
Tagging @sophiemeakin
> This seems like a good temporary fix and the code changes seem fine - but I wonder why this is happening? Some thoughts: My first q would be is...
Possibly but it needs to be revisited and your bullet points addressed. I've converted it to a draft for now.
I've split this up into multiple fix/feature branches through copious use of `git cherry-pick`. As far as I can tell the only remaining changes here relate to vscode and docker.
Precomputing the PMFs is of course a good idea to improve performance. This now contains the changes from #311 and #312 but implements the precomputation in the `transformed data` block...
It includes the improved discrete convolution from #311 - not sure how that relates to the `convolve_pmf`. It doesn't contain anything from `convolve_pmf` explicitly.
Yes, I agree, and also this may or may not be superseded by #305.
If https://github.com/epiforecasts/EpiNow2/pull/307 is eventually merged one could then perhaps also have covariates or a GP prior on e.g. the scaling factor.