Sam Clegg

build.py should not import emscripten python internals

2

build.py currently does `import tools.shared as emscripten` then uses it for a few things. This kind of use of emscripten internals is almost certainly going to break over time. Lets...

See https://github.com/emscripten-core/emscripten/issues/14783 I'm not familiar with how BrowserFS is used but in order to use emscripten's `$ERRNO_CODES` it somehow needs to be pulled in as a dependency (for library JS...

The float versions below already have `static const` so I assume these should be too.

LegalizeJSInterface: Look for get/setTempRet0 as exports

2

This allows emscripten to move these helper functions from JS library imports to native wasm exports. This change continues to support `getTempRet0/setTempRet0` as imports while we transition emscripten. See https://github.com/emscripten-core/emscripten/pull/17581...

Move `auto_update_tests.py` into scripts directory. NFC

2

So it lives alongside `update_lit_checks.py` and `update_help_checks.py`

Crash in Memory64Lowering

10

When working on getting this emscripten test to pass (` ./tests/runner wasm64l.test_stack_placement_pic`) I ran into this binaryen crash. ``` $ gdb --args wasm-opt --strip-dwarf --memory64-lowering --strip-debug --strip-producers test_stack_placement.wasm -o test_stack_placement.wasm...

simd seem to break --memory64-lowering

3

If I take a simple SIMD test from emscripten and build with `MEMORY64=2` (lowering) I get errors like this one: ``` $ wasm-opt --memory64-lowering --strip-producers in.wasm -o out.wasm -g --mvp-features...

segfault in wasm-opt

4

I'm seeing this with quite a lot of wasm64 tests in emscripten: ``` wasm-opt: /usr/local/google/home/sbc/dev/wasm/binaryen/src/wasm.h:715: T *wasm::Expression::cast() [T = wasm::Const]: Assertion `int(_id) == int(T::SpecificId)' failed. emcc: error: '/usr/local/google/home/sbc/dev/wasm/binaryen-out/bin/wasm-opt --memory64-lowering --strip-producers...

Missing 64-bit AtomicCmpxchg causes `__sync_fetch_and_nand` to fail under wasm2js

2

Usage of `__sync_fetch_and_nand` with 64-bit operands in emscripten causes the following error: ``` wasm2js: /usr/local/google/home/sbc/dev/wasm/binaryen/src/passes/I64ToI32Lowering.cpp:471: void wasm::I64ToI32Lowering::visitAtomicCmpxchg(wasm::AtomicCmpxchg *): Assertion `curr->type != Type::i64 && "64-bit AtomicCmpxchg not implemented"' failed. ``` I...

We build binaryen with g++-7 as part of emsdk CI and we are getting unused variable warning regarding: https://github.com/WebAssembly/binaryen/blob/3c1c8ae829d0026024de55aa65dc3d49bd8fd37a/src/passes/GlobalRefining.cpp#L57-L61 See https://app.circleci.com/pipelines/github/emscripten-core/emsdk/1385/workflows/d696706d-f612-429d-94ae-12b0742e7cfb/jobs/7067?invite=true#step-105-303 This seems to not effect g++-8 and above or...